Avoid duplicate planner failure cards - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planner_request_failedwarnings as the single actionable Retry/Providers presentationRoot cause
Planner request failures are recorded as actionable warning events, while their terminal run snapshot is marked failed.
runResponseFromSnapshotsynthesized a generic error for every failed snapshot without an explicit error event, so the side panel rendered both the planner warning card and a second generic error card.User impact
A failed planner request now shows one actionable error card instead of two duplicate presentations. Other failure types retain their existing fallback error behavior.
Validation
node --check src/chrome/src/run-reconnect.jsnode --check src/firefox/src/run-reconnect.jsnpm run test:security— 60/60 checks passedpackage.jsonis26.0.10while the changelog latest entry is26.0.0