Skip to content

Avoid duplicate planner failure cards - #227

Merged
esokullu merged 1 commit into
mainfrom
codex/fix-planner-error-duplication
Aug 3, 2026
Merged

Avoid duplicate planner failure cards#227
esokullu merged 1 commit into
mainfrom
codex/fix-planner-error-duplication

Conversation

@esokullu

@esokullu esokullu commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep planner_request_failed warnings as the single actionable Retry/Providers presentation
  • prevent reconnect snapshot recovery from synthesizing a second generic error for the same planner failure
  • preserve generic error synthesis for ordinary failed snapshots and existing error events
  • add mirrored Chrome and Firefox regression coverage

Root cause

Planner request failures are recorded as actionable warning events, while their terminal run snapshot is marked failed. runResponseFromSnapshot synthesized a generic error for every failed snapshot without an explicit error event, so the side panel rendered both the planner warning card and a second generic error card.

User impact

A failed planner request now shows one actionable error card instead of two duplicate presentations. Other failure types retain their existing fallback error behavior.

Validation

  • node --check src/chrome/src/run-reconnect.js
  • node --check src/firefox/src/run-reconnect.js
  • new Chrome/Firefox planner snapshot regression passes
  • npm run test:security — 60/60 checks passed
  • main suite — 1,432 passed; one unrelated existing failure remains because package.json is 26.0.10 while the changelog latest entry is 26.0.0

@esokullu
esokullu marked this pull request as ready for review August 3, 2026 15:42
@esokullu
esokullu merged commit fec4663 into main Aug 3, 2026
5 checks passed
@esokullu
esokullu deleted the codex/fix-planner-error-duplication branch August 3, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant