Escape AX inventory values to clear CodeQL alerts on #320 - #327
Merged
esokullu merged 1 commit intoAug 29, 2026
Merged
Conversation
CodeQL flagged incomplete sanitization because input/textarea values escaped quotes without first escaping backslashes. Always escape \\ then " in value= tokens, and parse those escapes back so metadata readback still sees the app-owned string. Co-authored-by: Emre Sokullu <esokullu@gmail.com>
esokullu
marked this pull request as ready for review
August 29, 2026 17:51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
esokullu
merged commit Aug 29, 2026
03b4422
into
codex/report-driven-adapter-workflows
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two GitHub Advanced Security / CodeQL high alerts on #320:
Where:
src/chrome/src/content/accessibility-tree.jsand the Firefox mirror,appendAxValue(input/textarea path).What:
value=tokens now always escape\then", matching the already-safe identity/innerTextpath. Inventory readback parses escaped quotes and restores the app-owned string so YouTube/form metadata verification still matches titles likeLaunch "Video" from C:\Temp.Chrome/Firefox shared modules stay byte-identical. Stacked on
codex/report-driven-adapter-workflowsso #320 picks this up when merged.Tests
node test/run.js: 2142 passed. The remaining failure is pre-existing on the #320 branch (adapter workflow jobs reach the executor...—taskKeyvs emptyevidenceTaskKey) and is not caused by this escape fix.