Skip to content

feat(led_strip): add shift functions#66

Merged
finger563 merged 3 commits intomainfrom
feature/led-strip-shift
Jun 5, 2023
Merged

feat(led_strip): add shift functions#66
finger563 merged 3 commits intomainfrom
feature/led-strip-shift

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Jun 5, 2023

Description

  • Added shift_left and shift_right functions to led_strip to be able to push/pull data through the strip more easily for very basic animations
  • Updated example name in haptics cmakelists
  • Updated led_strip example to use shift function for rainbow animation effect
  • Rebuilt docs

Motivation and Context

The original example code had some slightly hacky way of shifting the color data through the LED matrix, but this new code actually shifts properly (and the code is much easier to read now).

How has this been tested?

Building and running the example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

led_strip_shift.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Added shift_left and shift_right functions to led_strip to be able to push/pull data through the strip more easily for very basic animations
* Updated example name in haptics cmakelists
* Updated led_strip example to use shift function for rainbow animation effect
* Rebuilt docs
@finger563 finger563 added enhancement New feature or request led_strip labels Jun 5, 2023
@finger563 finger563 merged commit f447938 into main Jun 5, 2023
@finger563 finger563 deleted the feature/led-strip-shift branch June 5, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request led_strip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant