fix(test-stand): Fix missing motor init on test stand hardware - #16
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull request overview
This PR addresses a startup gap in the TinyS3 Test Stand hardware configuration by initializing the motor before it is retrieved/used, and also updates the project’s dependency lockfile.
Changes:
- Initialize the TinyS3 Test Stand motor during
app_main()setup. - Update
dependencies.lock(multiple component version bumps, plus new/updated dependency entries).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main/main.cpp | Initializes the test-stand motor before creating the haptics controller. |
| dependencies.lock | Updates locked component hashes/versions (includes an IDF patch bump). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+59
to
61
| auto motor_config = test_stand.default_motor_config; | ||
| test_stand.init_motor(motor_config); | ||
| auto motor = test_stand.motor(); |
ESP-IDF Size Report for 'Software Defined Haptics'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.Hardware