Skip to content

Add 3 utility packages to Espanso Hub: escape, repeat, snipbank#188

Merged
smeech merged 1 commit into
espanso:mainfrom
dicksonlaw583:dev-add-dicksonlaw583-packages
Sep 11, 2025
Merged

Add 3 utility packages to Espanso Hub: escape, repeat, snipbank#188
smeech merged 1 commit into
espanso:mainfrom
dicksonlaw583:dev-add-dicksonlaw583-packages

Conversation

@dicksonlaw583

Copy link
Copy Markdown
Contributor

I would like to add 3 packages to the Espanso Hub:

  • Escape: Encode and decode escape sequences in JSON/backslash, XML, URL encoding, and regular expression notation
  • Repeat: Type pieces of text on repeat
  • Snipbank: A snippet manager that supports collecting new snippets using ,,.. and removing them ..,,. Form creation is also supported. It can be used as a dynamic clipboard.

@smeech smeech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three packages, heavily dependent on a multitude of Python helper scripts. Passes the automated checks.
Those in escape and repeat are quite straightforward, converting and returning text in different formats.
The scripts in snipbank are more complex and rely on the Espanso environment to supply user-entered data as inputs. No apparently malicious or insecure code in this context.

I was a little concerned that hub-frontend might choke on the .gitignore file outside the versioned package folders, and prevent the packages appearing there. DeepWiki assures me it won't. 🤞

I'm inclined to merge, but as it's more complex than most I'd welcome another pair of eyes on it first.

@smeech smeech requested a review from AucaCoyan August 24, 2025 22:22
@smeech

smeech commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

I would still like someone to look at this (especially the snipbank package which creates and modifies files in the filesystem) and comment before I merge. I have forked the author's repo and removed all but their contributions so that DeepWiki can analyse it. It raises some concerns about general vulnerability although the packages appear safe, with risks depending on user-inputs.

@joh6nn

joh6nn commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

I wouldn't claim to be more than an intermediate level python dev, and as such I can't make any guarantees here. That said: this looks cleaner and better documented than some of the code I've written. Nothing here immediately jumps out at me as either dangerous or malicious.

@smeech

smeech commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Thank you. I'm sure there's nothing malicious. Just wanted to check it's safe enough for the Espanso "brand".

@smeech smeech merged commit 13eb7d6 into espanso:main Sep 11, 2025
1 check passed
@dicksonlaw583 dicksonlaw583 deleted the dev-add-dicksonlaw583-packages branch September 11, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants