[micro_wake_word] Version 2 - #7032
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7032 +/- ##
==========================================
+ Coverage 53.70% 53.78% +0.07%
==========================================
Files 50 50
Lines 9408 9660 +252
Branches 1654 1704 +50
==========================================
+ Hits 5053 5196 +143
- Misses 4056 4140 +84
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
jesserockz
left a comment
There was a problem hiding this comment.
Here is my initial review. I have not looked at everything yet.
We have the tflite component loaded now in CI, so #ifndef CLANG_TIDY can be removed from the source files.
|
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Thanks for the initial review! I made those changes and fixed the things clang tidy was complaining about:
|
jesserockz
left a comment
There was a problem hiding this comment.
Forgot we should change the shorthand url builder to have the v2 directory
https://github.com/esphome/esphome/pull/7032/files#diff-7dd4ab6d5bf5e2bc507a1a67e15a8aa9b206c8d285bbe47be228a71f0de749c2R271
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What does this implement/fix?
Adds support for microWakeWord version 2 models.
The old microWakeWord models will still work with this version of the component, but they cannot run simultaneously with the new models. It is a breaking change as the YAML configuration has changed to support listing multiple models.
Types of changes
Related issue or feature (if applicable): not applicable
Pull request in esphome-docs with documentation (if applicable): esphome/esphome.io#4015
Test Environment
Example entry for
config.yaml:Ensure you are running the ESPHome dev branch!
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: