Skip to content

Conversation

@f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Dec 26, 2024

Description

This PR adds the following improvements:

  • On pull request page, keeps a single comment with PR preview link after most recent commit(s) pushed
  • Fixes issues with non-working buttons on the homepage if baseURL has a subdir (pr)
  • On preview site, adds a link back to the original pull request

Issues with the article shortcode

Our PR previews have issues showing the featured articles. The problem lies in the fact that our PR preview's baseURL has a subdir pr<pr-number>. While creating links to articles, the article shortcode discards the baseURL's subdir at some point.

As part of this PR, I tried to fix this issue, but it is way over my level of expertise.

Related links:

Related

Testing

Tested all changes in this testing environment.

@f-hollow
Copy link
Collaborator Author

All changes appear to be working as expected. Merging this PR.

@f-hollow f-hollow merged commit 682bbe5 into espressif:main Dec 26, 2024
4 checks passed
@f-hollow f-hollow deleted the ci/improve_previews_and_preview_ux branch December 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant