Waypoint bugfix #2083
Merged
Waypoint bugfix #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks - that's very strange though since I'm pretty sure we've done similar things all over the place. I'll merge this but will also see if I can figure out what's wrong with the interpreter itself that causes this error |
gfwilliams
added a commit
to espruino/Espruino
that referenced
this pull request
Aug 10, 2022
Member
|
Ok, just found an issue inside Espruino so this should be fixed in firmwares 2v15 and later. Thanks for the PR and letting me know about the issue! |
Contributor
Author
|
Cool, thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current library for waypoints includes nested backticks for format string evaluation. However, when attempting to import this library (e.g. with
require("waypoints").load()such as in the Way Pointer app) I get the errorUncaught SyntaxError: Got EOF expected ':' at line 1 col 5 num? ^ at line 1 col 5 num? ^ in function "load" called from line 44 col 38 in waypointer.app.js var waypoints=require("waypoints").load();.This is fixed by removing the inner backticks and replacing them with string concatenation, which still appears to evaluate the format string correctly.