[Smart Battery Module] Update for greater accuracy #4068
Merged
+50
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed dynamic interval setting for battery recording and replaced it with a fixed update interval of 8 hours.
Update battery cycle and hour tracking logic to limit cycles to 60.
Return to fixed update intervals and added settings to change the update interval. Limited cycles to 60 for greater precision over longer periods.
Added details about the update interval setting for battery drainage recording.
Collaborator
|
LGTM, will merge if you're happy with testing |
Contributor
Author
|
Yeah, testing on my end looks good, we can merge if you're happy with this :) |
Collaborator
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following: