-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[CSS] Enhance UI, and add animations for an overall cleaner look #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removed unnecessary whitespace and added styles for modal and device chooser.
|
I like the look of this - round feels friendly. tagging @gfwilliams |
Updated styles for various elements including navbar, container, and tabs.
|
Since I've made commits in here in order to bring my index.js changes, I'll mark this as a draft, and when everyone likes the new look, then I'll make a new PR with only code changes from this repository. |
|
Hmm, this is from a phone, right? What model? I think we can just adjust the pixel thresholds for it to become one list... What do you think of the tabs now? I added a bit of an animation, and tried to keep the existing style, while making it cleaner. |
|
I can just drag the window on desktop to be narrow and it happens too. It used to dynamically choose between 1 and 2 columns wide depending on the screen width, which I think was a really nice addition, so I'd really like to keep that functionality. I'm losing track of issues/PRs now, but also I'd mentioned that it would be really cool if the text could go right to the edge of the box (eg the buttons in the top-right didn't take up the entire column). That's probably not a CSS-only thing, but it would be a really good improvement IMO. |
|
One more note on this: We need to make sure that espruino/EspruinoAppLoaderCore#82 doesn't break https://espruino.github.io/EspruinoApps/ which also uses it (also https://pip-boy.com/3000-mk-v/apps does too). I don't think that will be an issue right now but it's worth bearing in mind that other sites use the same code |
|
Ok, I can test it out and fix the 1-2 column switching. It also used to work here, but I think another piece of css has broken it. |
It only started doing that weird split on my phone after c560860 I think. |
|
Thanks! That should be fixed now. @gfwilliams I've tried out what it looks like with only the index.js for other sites that use AppLoaderCore, and it looks mostly good, I will add some padding styled into the HTML to make sure that works. Obviously for the sites that don't have the updated css, they won't have the animations, but hopefully it won't look unpadded and strange. |
|
Or the other option for pip boy is that they just don't update the apploadercore submodule to it's latest version, which they don't do anyway. |


There is a discussion for this where you can give your opinion to make this better here!
Description
As I was making a PR to improve favorites handling in AppLoaderCore, I noticed certain visual discrepancies and errors with the App Loader, such as a number in the 100s for favorites often clipping past the icon and becoming less readable as a result, so I decided to somewhat modernise the interface to feel fresh, as well as fix layout bugs and errors.
It is up on my personal app loader, if anyone wants to take a look. It doesn't have the updated
AppLoaderCoreto go along with it, so it won't have the pills and updated favorite buttons yet. What's up right now on my app loader is what the main. app loader will look like after this is merged. Anyone is welcome to pop in, take a look, and share what you think!This PR, along with EspruinoAppLoaderCore #82:
This PR addresses all the stylistic changes, EspruinoAppLoaderCore #82 addresses the favorite animations and layout. These CSS changes are designed to work with the current version of
AppLoaderCore, so both do not need to be merged at the same time, however, this needs to be merged first.No user functionality was changed with this, this is purely a cosmetic upgrade to help the app loader feel fresh and fix bugs.
Screenshots
Before
After
Before
After
Favorites Animations
Screen.Recording.2025-12-01.at.3.36.54.PM.mov