Improve Docker daemon diagnostics for local flowctl runs#3001
Open
RitwijParmar wants to merge 1 commit into
Open
Improve Docker daemon diagnostics for local flowctl runs#3001RitwijParmar wants to merge 1 commit into
RitwijParmar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2969 by detecting Docker daemon/connectivity failures from
dockerstderr even when the Docker CLI exits successfully.Docker Desktop on macOS can return status 0 while writing the real daemon failure to stderr. Before this change,
flowctl preview/flowctl catalog testcould continue intodocker inspectparsing and surface a misleading error like:This now returns an actionable message telling the user to start Docker Desktop or their configured container runtime, with a note about
DOCKER_CLI=podman.What changed
docker_cmd_outputin both runtime paths:crates/runtime/src/container.rscrates/runtime-next/src/container.rsCannot connect to the Docker daemon....[]stdoutflowctl previewandflowctl catalog testworkflows incrates/flowctl/README.md.Validation
Passed locally: