control-plane-api: Add tenant filter to dataPlanes query - #3437
Merged
Conversation
adrian-estuary
commented
Aug 28, 2026
Contributor
Author
There was a problem hiding this comment.
Added a couple of fixtures to represent a single user (bob) having admin access to two tenants (bobCo and bobCo2) so that I could test the new tenant filter for data planes.
adrian-estuary
commented
Aug 28, 2026
5 tasks
adrian-estuary
force-pushed
the
2065-filter-data-plane-tenant
branch
2 times, most recently
from
August 28, 2026 21:20
e07b7a1 to
ed537b4
Compare
adrian-estuary
commented
Aug 31, 2026
Contributor
|
This looks good, you get my approval. Just finishing reviewing things from Greg and you should be fine. |
bbartman
reviewed
Aug 31, 2026
bbartman
left a comment
bbartman
left a comment
Contributor
There was a problem hiding this comment.
This looks good from a backend perspective.
GregorShear
reviewed
Aug 31, 2026
adrian-estuary
force-pushed
the
2065-filter-data-plane-tenant
branch
from
September 1, 2026 16:46
b7ee022 to
3f71069
Compare
GregorShear
reviewed
Sep 1, 2026
Fixes the edge-case where result set has exactly `limit` items, causing `hasNext` to incorrectly return `true`. This would cause clients to have to query for an empty last page unnecessarily.
GregorShear
approved these changes
Sep 1, 2026
github-actions
Bot
added
pending:agent-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related to estuary/ui#2065
Adding a new
tenantstring filter to allow filtering the DataPlanesQuery results to just data planes owned by that tenant. This is required to migrate the DataPlanesTable to GQL, since the current supabase query does this filtering.Filter by tenant
acmeCo/Filter by tenant
umbrellaCo/Includes public data planes by default
Workflow steps:
The filter will be used by the data planes table in the admin UI to filter planes to the selected tenant.
Documentation links affected:
No documentation changed.
Notes for reviewers: