fix(release): unblock snap publish + stop release.yml double-building snap#11
Merged
Conversation
Two issues surfaced on the v0.2.0 tag's first run: 1. snap-publish.yml's "Build snap" step failed because electron-builder detected the git tag and attempted an implicit publish to the Snap Store from inside the build job. SNAPCRAFT_STORE_CREDENTIALS is scoped to the dedicated publish-edge / publish-stable jobs only, so the build's keyring lookup failed and the workflow died before the snap was even uploaded as an artifact. Pass --publish never to the build step; the dedicated publish jobs use snapcore/action-publish with the credentials properly scoped. 2. release-linux's package step tried to build all three Linux targets from the electron-builder.yml (AppImage, deb, snap), which is redundant with snap-publish.yml AND triggers the same implicit- publish behaviour. Pass an explicit "AppImage deb" target list so this job only owns AppImage + deb. Snap is exclusively owned by snap-publish.yml. (The release-linux run for v0.2.0 also showed an AppImage cache rename race during the snap step — moot once snap is removed from this job. The actual AppImage and deb artefacts uploaded successfully and are on the v0.2.0 GitHub Release page; this commit just stops the spurious failure.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.2.0's first run revealed two release-pipeline issues:
snap-publish.yml failed at the build step because electron-builder, on detecting a git tag, tried to publish to the Snap Store from inside the build job — which doesn't have SNAPCRAFT_STORE_CREDENTIALS (those are scoped to the publish-edge / publish-stable jobs). Adds `--publish never` to the build invocation; the dedicated publish jobs use `snapcore/action-publish` with credentials properly scoped.
release.yml's release-linux job was building all three linux targets (AppImage, deb, snap) and hit the same implicit-publish trap on the snap step. Constrains it to `--linux AppImage deb`; snap is exclusively owned by snap-publish.yml.
The v0.2.0 tag's AppImage / .deb / Windows artefacts shipped successfully despite the workflow showing failure. Snap publish needs a re-trigger after this lands.
🤖 Generated with Claude Code