feat(sheet): Min/Max in the status-bar stats - #363
Merged
Conversation
Excel's status bar shows Average/Count/Min/Max/Sum for a numeric selection; we only had Average/Count/Sum. Adds Min and Max to the same single-pass scan. E2e assertion extended. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
PR Summary by Qodofeat(sheet): Add Min/Max to spreadsheet status-bar stats
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The spreadsheet status bar shows Average/Count/Sum for a numeric multi-cell selection. Excel also shows Min and Max — this adds them (order: Average, Count, Min, Max, Sum).
How
Two extra accumulators in the existing single-pass
updateStatsscan; formula cells count with their computed value, same as the other stats. SamenumCount === 0guard.Tests
Extended the existing
sheet_excel_chrome.spec.tsstatus-bar test withMin: 1/Max: 3assertions. Ran locally against a live server — passes. Sheet bundle builds clean; no new tsc errors.🤖 Generated with Claude Code