Add input validation for html param in setHTML() #2035
Merged
JohnMcLear merged 2 commits intoether:dont-die-on-bad-htmlfrom Dec 16, 2013
lebrinkma:dont-die-on-bad-html
Merged
Add input validation for html param in setHTML() #2035JohnMcLear merged 2 commits intoether:dont-die-on-bad-htmlfrom lebrinkma:dont-die-on-bad-html
JohnMcLear merged 2 commits intoether:dont-die-on-bad-htmlfrom
lebrinkma:dont-die-on-bad-html
Conversation
Member
There was a problem hiding this comment.
Does this really qualify as input validation? :)
Contributor
Author
There was a problem hiding this comment.
@JohnMcLear
It's a basic input validation. :)
It fixes the server crashes if setHTML is called with no html parameter.
I stumbled across this issue when calling setHTML with the parameter text instead of html as the doc in current develop states.
The doc is already fixed in this branch.
You are welcome to propose a better fix for this issue.
JohnMcLear
added a commit
that referenced
this pull request
Dec 16, 2013
Add input validation for html param in setHTML()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement to feature branch dont-die-on-bad-html:
Add input validation for html param in setHTML(), see my comment on #1449
This also fixes a duplicate doc entry in the dont-die-on-bad-html branch.