Skip to content

feat(unit tests): support transaction types in fill unit tests #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marioevz merged 1 commit into from
Feb 13, 2025
Merged

feat(unit tests): support transaction types in fill unit tests #1215

marioevz merged 1 commit into from
Feb 13, 2025

Conversation

@winsvega
Copy link
Contributor

@winsvega winsvega commented Feb 13, 2025 •
edited
Loading

🗒️ Description

add access list transaction for filling unit test

🔗 Related Issues

Discovered this issue. that eels t8n rejects access list transaction if its chain id 0
not sure if it's a correct behavior

ethereum/execution-specs#1514

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added the scope:fill Scope: fill command label Feb 13, 2025
@winsvega winsvega requested a review from marioevz February 13, 2025 13:39
@winsvega winsvega changed the title support transaction types in fill unit tests feat(unit tests): support transaction types in fill unit tests Feb 13, 2025
marioevz
marioevz approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 38621dc into main Feb 13, 2025
21 checks passed
@marioevz marioevz deleted the tx_type_unit_test branch February 13, 2025 16:23
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@winsvega @felix314159
feat(specs): support transaction types in fill unit tests (ethereum#1215
f90275f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz approved these changes

Assignees

No one assigned

Labels

scope:fill Scope: fill command

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winsvega @marioevz