Skip to content

fix(test-logging): don't store empty logs#2547

Merged
danceratopz merged 1 commit intoethereum:forks/amsterdamfrom
felix314159:no-empty-logs
Mar 24, 2026
Merged

fix(test-logging): don't store empty logs#2547
danceratopz merged 1 commit intoethereum:forks/amsterdamfrom
felix314159:no-empty-logs

Conversation

@felix314159
Copy link
Copy Markdown
Contributor

🗒️ Description

Before this PR, when u run e.g. uv run fill --pytest-help it will create an empty log file. I have noticed empty log files in the past and this is just a minimal example to demonstrate it.

The PR fixes it so that no completely empty log files are created. Writing non-empty logs still works, e.g. run uv run fill -v -s --no-html --clean 'tests/frontier/touch/test_touch.py::test_zero_gas_price_and_touching[fork_Frontier-state_test]' after applying the PR.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.35%. Comparing base (878ef15) to head (0000000).
⚠️ Report is 5 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2547   +/-   ##
================================================
  Coverage            86.35%   86.35%           
================================================
  Files                  599      599           
  Lines                36904    36904           
  Branches              3771     3771           
================================================
  Hits                 31868    31868           
  Misses                4485     4485           
  Partials               551      551           
Flag Coverage Δ
unittests 86.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz danceratopz added C-bug Category: this is a bug, deviation, or other problem A-test-logging Area: execution_testing.logging labels Mar 24, 2026
Copy link
Copy Markdown
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felix314159. TIL delay=True!

@danceratopz danceratopz changed the title fix(logging): don't store empty logs fix(test-logging): don't store empty logs Mar 24, 2026
@danceratopz danceratopz merged commit b1cb9eb into ethereum:forks/amsterdam Mar 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-logging Area: execution_testing.logging C-bug Category: this is a bug, deviation, or other problem P-low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants