feat(spec): EIP-8237 partial header hash#2770
Draft
nerolation wants to merge 7 commits into
Draft
Conversation
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following ethereum#2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
Replace stale GAS_BASE reference with GasCosts.OPCODE_SLOTNUM (= BASE) to match the opcode gas naming convention used across block instructions on forks/amsterdam. Also update the test-fork mixin to use gas_costs.BASE instead of the retired gas_costs.GAS_BASE.
nerolation
force-pushed
the
toni/eip-8237
branch
from
1afffda to
79b08f2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2770 +/- ##
===================================================
- Coverage 88.17% 87.82% -0.36%
===================================================
Files 577 525 -52
Lines 35659 31930 -3729
Branches 3490 3082 -408
===================================================
- Hits 31442 28042 -3400
+ Misses 3654 3373 -281
+ Partials 563 515 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
EIP-8237: Partial Header Hash implementation
Header.partial_header_hash(last RLP field, included inblock_hash)compute_partial_header_hash: SHA2-256 over (parent_hash || prev_randao || gas_limit_LE || timestamp_LE || withdrawals(44B) || slot_LE || requests)ExecutionPayload; STF checkspayload == expected == headerengine_getPartialHeaderHashByBlockHashV1for debugging🔗 Related Issues or PRs
N/A.
✅ Checklist