Skip to content

refactor(tests): parametrize max_code_size for EIP-3860 & 1153#2780

Merged
LouisTsai-Csie merged 1 commit intoethereum:forks/amsterdamfrom
monad-developers:fix/parametrize-tests
May 7, 2026
Merged

refactor(tests): parametrize max_code_size for EIP-3860 & 1153#2780
LouisTsai-Csie merged 1 commit intoethereum:forks/amsterdamfrom
monad-developers:fix/parametrize-tests

Conversation

@pdobacz
Copy link
Copy Markdown
Contributor

@pdobacz pdobacz commented Apr 29, 2026

🗒️ Description

As title - avoid hardcoding max code/initcode size in two tests

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.62%. Comparing base (6333758) to head (8ce7946).
⚠️ Report is 8 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2780      +/-   ##
===================================================
+ Coverage            88.17%   88.62%   +0.45%     
===================================================
  Files                  577      577              
  Lines                35659    35659              
  Branches              3490     3490              
===================================================
+ Hits                 31442    31604     +162     
+ Misses                3654     3492     -162     
  Partials               563      563              
Flag Coverage Δ
unittests 88.62% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisTsai-Csie LouisTsai-Csie added the A-tests Area: Consensus tests. label May 6, 2026
@LouisTsai-Csie LouisTsai-Csie changed the title fix(tests): EIP-3860 & 1153 - parametrize max_code_size refactor(tests): parametrize max_code_size for EIP-3860 & 1153 May 6, 2026
@LouisTsai-Csie LouisTsai-Csie added the C-refactor Category: refactor label May 6, 2026
Copy link
Copy Markdown
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a small comment, thank you!

Comment thread tests/cancun/eip1153_tstore/test_tstorage_create_contexts.py
@pdobacz pdobacz force-pushed the fix/parametrize-tests branch from 429ba49 to 8ce7946 Compare May 6, 2026 07:47
@pdobacz pdobacz requested a review from LouisTsai-Csie May 6, 2026 07:48
Copy link
Copy Markdown
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LouisTsai-Csie LouisTsai-Csie merged commit 8671966 into ethereum:forks/amsterdam May 7, 2026
18 checks passed
@pdobacz pdobacz deleted the fix/parametrize-tests branch May 7, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-refactor Category: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants