test(test-benchmark): add bn128_add precompile special case benchmarks#2811
Merged
LouisTsai-Csie merged 2 commits intoethereum:forks/amsterdamfrom May 7, 2026
Merged
Conversation
…performance-wise from general addition.
…ase where the second point is the negative of the first. (so the result is the point at infinity)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2811 +/- ##
===================================================
+ Coverage 88.17% 88.62% +0.45%
===================================================
Files 577 577
Lines 35659 35659
Branches 3490 3490
===================================================
+ Hits 31442 31604 +162
+ Misses 3654 3492 -162
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
May 7, 2026
Collaborator
LouisTsai-Csie
left a comment
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
LGTM, thank you for the new cases
LouisTsai-Csie
changed the title
bn128_add precompile special case benchmarks
LouisTsai-Csie
added
A-test-benchmark
LouisTsai-Csie
changed the title
bn128_add precompile special case benchmarksbn128_add precompile special case benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This adds 2 new benchmark tests regarding the ecAdd precompile. Notably,
we include test cases for the special cases where we
These cases are highly likely to require different code paths in most implementations, to we should benchmark them separately.