Skip to content

feat(spec,test): update bal-devnet-7 EIP-8037 bytes values; CPSB 1174 -> 1530#2827

Merged
spencer-tb merged 9 commits into
ethereum:devnets/bal/7from
fselmo:fix/update-bytes-values
May 10, 2026
Merged

feat(spec,test): update bal-devnet-7 EIP-8037 bytes values; CPSB 1174 -> 1530#2827
spencer-tb merged 9 commits into
ethereum:devnets/bal/7from
fselmo:fix/update-bytes-values

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented May 8, 2026

🗒️ Description

This PR is an attempt to do a sweeping update of the devnets/bal/7 branch, mostly for the changes introduced to EIP-8037 via this PR. This is part of the updates for tracking issue #2804.

  • Update "state_bytes_per_X" values to agreed values
  • Update the CPSB from 1174 to 1530
  • Fix failing tests in the most future-proof way
    • Use dynamic gas accounting, utilizing opcode / bytecode metadata and fork gas constants instead of hard-coding where possible
    • Attempt to sanity check the proper gas accounting when possible by adding header_verify checks with our math so that we can be a bit more certain of these calculations as a reader
  • Updates some ported_static tests and adds the @manually-enhanced tag so these changes are not overridden by some hypothetical future run of the script that ported the legacy tests

Wait for #2823 and rebase as I believe some fails are related to the spec update there. [done]

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (devnets/bal/7@9d3906e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             devnets/bal/7    #2827   +/-   ##
================================================
  Coverage                 ?   85.58%           
================================================
  Files                    ?      630           
  Lines                    ?    39600           
  Branches                 ?     3936           
================================================
  Hits                     ?    33891           
  Misses                   ?     5084           
  Partials                 ?      625           
Flag Coverage Δ
unittests 85.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo force-pushed the fix/update-bytes-values branch 2 times, most recently from 9c46de3 to 7b46aa8 Compare May 8, 2026 19:41
@fselmo fselmo changed the title [WIP] feat(spec,test): update bal-devnet-7 EIP-8037 bytes values feat(spec,test): update bal-devnet-7 EIP-8037 bytes values; CPSB 1174 -> 1530 May 8, 2026
@fselmo fselmo added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature C-test Category: test labels May 8, 2026
@fselmo fselmo force-pushed the fix/update-bytes-values branch from 7b46aa8 to a6475db Compare May 8, 2026 20:13
@fselmo fselmo marked this pull request as ready for review May 8, 2026 20:15
@fselmo fselmo requested review from kclowes and spencer-tb May 8, 2026 20:15
@fselmo fselmo force-pushed the fix/update-bytes-values branch 3 times, most recently from d4aa994 to b8bcc3c Compare May 8, 2026 20:40
Replace hardcoded literals (112, 23, 32) in EIP-8037 test docstrings
and comments with their symbolic names (STATE_BYTES_PER_NEW_ACCOUNT,
STATE_BYTES_PER_AUTH_BASE, STATE_BYTES_PER_STORAGE_SET, cpsb) so the
prose stays correct when parameter values change. Also corrects a
misleading comment in cancun/test_selfdestruct.py that referred to
"EIP-1706 slack" when the added term is actually EIP-8037 state gas.
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just changed some docstrings.

@spencer-tb spencer-tb merged commit 2e707c2 into ethereum:devnets/bal/7 May 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature C-test Category: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants