Skip to content

feat(test): add besu main overflow test#2933

Open
felix314159 wants to merge 1 commit into
ethereum:forks/amsterdamfrom
felix314159:besu-overflow-test
Open

feat(test): add besu main overflow test#2933
felix314159 wants to merge 1 commit into
ethereum:forks/amsterdamfrom
felix314159:besu-overflow-test

Conversation

@felix314159
Copy link
Copy Markdown
Contributor

@felix314159 felix314159 commented May 28, 2026

🗒️ Description

Theoretic case about max balance, not security-relevant cuz not reachable on mainnet. But I did verify via hive that only besu fails and geth/erigon/nethermind main/master all pass.

wdyt?

from eels root folder fill with:
uv run fill tests/frontier/validation/test_recipient_balance_overflow.py --until=Osaka --clean -v -s

use the following clients.yaml in hive directory:

- client: besu
  nametag: default
  dockerfile: git
  build_args:
    github: besu-eth/besu
    tag: main

set this in ~/.profile: export HIVE_SIMULATOR=http://127.0.0.1:3000 and source it

ensure you are on latest hive master branch, then start hive with:

go run . --docker.nocache=besu --docker.buildoutput --docker.output --client=besu --client-file=clients.yaml --dev --loglevel=5 --sim.loglevel=5

and from eels root folder run the tests with:
uv run consume engine ./fixtures/blockchain_tests_engine/ -v -s

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Cute Animal Picture

@felix314159 felix314159 added P-low C-test Category: test labels May 28, 2026
@felix314159
Copy link
Copy Markdown
Contributor Author

maybe wait with this PR until the 8037 stuff is merged to avoid conflict. i will have to rebase anyway

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.36%. Comparing base (c67cd90) to head (0000000).
⚠️ Report is 4 commits behind head on forks/amsterdam.

Files with missing lines Patch % Lines
src/ethereum/forks/amsterdam/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/berlin/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/byzantium/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/cancun/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/constantinople/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/frontier/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/homestead/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/istanbul/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/london/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/osaka/state_tracker.py 50.00% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2933      +/-   ##
===================================================
- Coverage            90.43%   90.36%   -0.07%     
===================================================
  Files                  535      535              
  Lines                32430    32469      +39     
  Branches              3012     3025      +13     
===================================================
+ Hits                 29329    29342      +13     
- Misses                2573     2587      +14     
- Partials               528      540      +12     
Flag Coverage Δ
unittests 90.36% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category: test P-low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant