feat(test): add besu main overflow test#2933
Open
felix314159 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
maybe wait with this PR until the 8037 stuff is merged to avoid conflict. i will have to rebase anyway |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2933 +/- ##
===================================================
- Coverage 90.43% 90.36% -0.07%
===================================================
Files 535 535
Lines 32430 32469 +39
Branches 3012 3025 +13
===================================================
+ Hits 29329 29342 +13
- Misses 2573 2587 +14
- Partials 528 540 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Theoretic case about max balance, not security-relevant cuz not reachable on mainnet. But I did verify via hive that only besu fails and geth/erigon/nethermind main/master all pass.
wdyt?
from eels root folder fill with:
uv run fill tests/frontier/validation/test_recipient_balance_overflow.py --until=Osaka --clean -v -suse the following
clients.yamlin hive directory:set this in
~/.profile:export HIVE_SIMULATOR=http://127.0.0.1:3000and source itensure you are on latest hive master branch, then start hive with:
go run . --docker.nocache=besu --docker.buildoutput --docker.output --client=besu --client-file=clients.yaml --dev --loglevel=5 --sim.loglevel=5and from eels root folder run the tests with:
uv run consume engine ./fixtures/blockchain_tests_engine/ -v -s🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture