feat(tests): EIP-2780 warm/cold-aware top-frame delegation#3045
Open
chfast wants to merge 1 commit into
Open
Conversation
Assert that an EIP-7702 delegation target already made warm via the access list is resolved at the WARM_ACCESS rate at the top transaction frame, per the EIP-2780 Interactions note (the EIP-2929 accessed_addresses model). EIP-2780 is internally inconsistent here: its normative top-level gas-cost bullet and reference-cases table charge an unconditional COLD_ACCOUNT_ACCESS, whereas the Interactions note specifies warm/cold-aware accounting. This probe pins the Interactions-note reading; test_warmth_invariants.py pins the unconditional-cold one. Marked xfail(strict=True): the implementation currently charges cold unconditionally, so the probe is CI-green today and a strict XPASS forces the marker's removal once the spec is disambiguated in favor of warm/cold-aware accounting and EELS adopts it.
Contributor
|
The scenario is already covered in this test. If we decide to update the spec and the implementation, could we just adapt that test? |
Member
Author
Yes, we can. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Assert that an EIP-7702 delegation target already made warm via the access list is resolved at the WARM_ACCESS rate at the top transaction frame, per the EIP-2780 Interactions note (the EIP-2929 accessed_addresses model).
EIP-2780 is internally inconsistent here: its normative top-level gas-cost bullet and reference-cases table charge an unconditional COLD_ACCOUNT_ACCESS, whereas the Interactions note specifies warm/cold-aware accounting. This probe pins the Interactions-note reading; test_warmth_invariants.py pins the unconditional-cold one.
Marked xfail(strict=True): the implementation currently charges cold unconditionally, so the probe is CI-green today and a strict XPASS forces the marker's removal once the spec is disambiguated in favor of warm/cold-aware accounting and EELS adopts it.
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture