fix: max balance < 2^128 in ported static tests - #3230
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3230 +/- ##
================================================
Coverage 93.41% 93.41%
================================================
Files 624 624
Lines 37014 37014
Branches 3386 3386
================================================
Hits 34576 34576
Misses 1668 1668
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
left a comment
There was a problem hiding this comment.
Some other files have values over 2**128, for example tests/ported_static/stMemoryStressTest/test_mstore_bounds2a.py
Should these be changed too or are these not causing any issues?
I wasn't getting an issue from those files, I believe some of the tests do not run past Amsterdam (that one I guess stops at Prague) |
Description
Related to #3229
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture