Skip to content

fix: max balance < 2^128 in ported static tests - #3230

Merged
spencer-tb merged 2 commits into
ethereum:forks/amsterdamfrom
kevaundray:kw/max-2-128-balance-more-fixes
Jul 27, 2026
Merged

fix: max balance < 2^128 in ported static tests#3230
spencer-tb merged 2 commits into
ethereum:forks/amsterdamfrom
kevaundray:kw/max-2-128-balance-more-fixes

Conversation

@kevaundray

Copy link
Copy Markdown
Contributor

Description

Related to #3229

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (1646cf5) to head (0c2453e).
⚠️ Report is 3 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3230   +/-   ##
================================================
  Coverage            93.41%   93.41%           
================================================
  Files                  624      624           
  Lines                37014    37014           
  Branches              3386     3386           
================================================
  Hits                 34576    34576           
  Misses                1668     1668           
  Partials               770      770           
Flag Coverage Δ
unittests 93.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other files have values over 2**128, for example tests/ported_static/stMemoryStressTest/test_mstore_bounds2a.py

Should these be changed too or are these not causing any issues?

@kevaundray

kevaundray commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Some other files have values over 2**128, for example tests/ported_static/stMemoryStressTest/test_mstore_bounds2a.py

Should these be changed too or are these not causing any issues?

I wasn't getting an issue from those files, I believe some of the tests do not run past Amsterdam (that one I guess stops at Prague)

@spencer-tb
spencer-tb merged commit 853585f into ethereum:forks/amsterdam Jul 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants