feat(tests): add ef_prefix deposit-halt mode to EIP-8037 state-gas test - #3233
Merged
spencer-tb merged 2 commits intoJul 27, 2026
Merged
Conversation
`test_code_deposit_halt_discards_initcode_state_gas` parametrized `deposit_fail_mode` over `oversized_code` and `oog_deposit` only. Add a third `ef_prefix` mode returning a single 0xEF byte: it passes the code-size check but is rejected by EIP-3541, a distinct deployment-halt path. With stateful initcode (`call_new_account` / `inner_create`) it must discard the initcode GAS_NEW_ACCOUNT state gas exactly like the other two modes. Filled fixtures confirm identical block gasUsed across all three modes. Closes ethereum#2963 Claude-Session: https://claude.ai/code/session_019YyttTB1mqHzWa77K3sEoT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3233 +/- ##
================================================
Coverage 93.41% 93.41%
================================================
Files 624 624
Lines 37014 37014
Branches 3386 3386
================================================
Hits 34576 34576
Misses 1668 1668
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_code_deposit_halt_discards_initcode_state_gasparametrizeddeposit_fail_modeoveroversized_codeandoog_depositonly. Add a thirdef_prefixmode returning a single 0xEF byte: it passes the code-size check but is rejected by EIP-3541, a distinct deployment-halt path. With stateful initcode (call_new_account/inner_create) it must discard the initcode GAS_NEW_ACCOUNT state gas exactly like the other two modes. Filled fixtures confirm identical block gasUsed across all three modes.Related Issues or PRs
Closes #2963
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.