feat(tests): EIP-7928 - cover system-address zero-tip coinbase BAL - #3239
Merged
marioevz merged 9 commits intoJul 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3239 +/- ##
================================================
Coverage 93.41% 93.41%
================================================
Files 624 625 +1
Lines 37014 37035 +21
Branches 3386 3386
================================================
+ Hits 34576 34597 +21
Misses 1668 1668
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marioevz
reviewed
Jul 28, 2026
marioevz
left a comment
marioevz
left a comment
Member
There was a problem hiding this comment.
Some comments to potentially simplify the test by removing unnecessary setup steps that constrained the test unnecessarily.
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
…cess_lists.py Co-authored-by: Mario Vega <marioevz@gmail.com>
marioevz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an Amsterdam BAL fixture for the case where
SYSTEM_ADDRESSis the fee recipient and the transaction priority fee is zero. The expected block access list includesSYSTEM_ADDRESSas an empty account entry because it is still touched by the transaction fee-credit path.Validation performed:
uv run ruff check tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.pyuv run ruff format --check tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.pyuv run pytest tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py::test_bal_system_address_coinbase_zero_tip --collect-only -qAttempted targeted
uv run fill ... --fork Amsterdam, but the local WSL run timed out before producing fixture output.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture
N/A for draft.