feat(tests): add EIP-7997 case where factory is not present at fork block - #3243
Merged
spencer-tb merged 1 commit intoJul 28, 2026
Conversation
Member
Author
|
CI directly turns red, I'll fix this tomorrow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3243 +/- ##
================================================
Coverage 93.41% 93.41%
================================================
Files 625 625
Lines 37035 37035
Branches 3386 3386
================================================
Hits 34597 34597
Misses 1668 1668
Partials 770 770
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Not your fault, it's because of this issue: #3241 |
Member
Author
|
Ah thanks for that information @marioevz, will wait until those are merged, ping if they need a review 😄 👍 |
jochem-brouwer
marked this pull request as ready for review
July 28, 2026 08:56
Member
|
@jochem-brouwer I think this just needs a simple rebase for it to pass the CI 👍 |
12 tasks
jochem-brouwer
force-pushed
the
eip-7997-no-create2-factory-at-fork
branch
from
July 28, 2026 13:45
eeac5d0 to
7171595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements tests where CREATE2 factory is not present at fork block. This also verifies that the factory account is not part of the BAL reads.
Related Issues or PRs
Discussed in ethereum/pm#2170
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture
This is Harry who has been keeping me company on my home's ceiling for a while. Hi Harry!