Skip to content

fix(test-execute): prune fork-less items before evaluating filter_combinations - #3259

Merged
marioevz merged 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/execute-collection-fork-less-items
Jul 29, 2026
Merged

fix(test-execute): prune fork-less items before evaluating filter_combinations#3259
marioevz merged 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/execute-collection-fork-less-items

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

In execute mode, tests that are not valid for the session fork are still collected as fork-less items without their covariant params, and the forks plugin's filter_combinations predicates ran before these items were pruned, aborting the whole session with an INTERNALERROR (e.g. any full tree execute hive --fork=Osaka run).

Related Issues or PRs

Surfaced by running execute blobs hive mode runs of #2948.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (178d9f9) to head (87fa3fe).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3259   +/-   ##
================================================
  Coverage            93.41%   93.41%           
================================================
  Files                  625      625           
  Lines                37035    37035           
  Branches              3386     3386           
================================================
  Hits                 34597    34597           
  Misses                1668     1668           
  Partials               770      770           
Flag Coverage Δ
unittests 93.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb added C-bug Category: this is a bug, deviation, or other problem A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute labels Jul 29, 2026
@spencer-tb
spencer-tb marked this pull request as ready for review July 29, 2026 13:59

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz
marioevz merged commit d3baec8 into ethereum:forks/amsterdam Jul 29, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants