fix(tests): un-skip remaining Amsterdam ported static tests and drop the skip list (Pt. 2d) - #3322
Draft
spencer-tb wants to merge 1 commit into
Draft
fix(tests): un-skip remaining Amsterdam ported static tests and drop the skip list (Pt. 2d)#3322spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
…the skip list (Pt. 2d)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3322 +/- ##
===================================================
- Coverage 93.50% 93.21% -0.29%
===================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
===================================================
- Hits 34661 34555 -106
- Misses 1653 1723 +70
- Partials 756 792 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
ported-static-pt2d
branch
from
August 5, 2026 15:58
51e0a7f to
6e54710
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Final slice of the Part 2 ported static split (chain in #3264): the remaining un-skips — including the stCreate2 Berlin-twin consolidation into single parametrized tests and the
revert_depth_create_address_collisionrestoration (the port never actually collided; the collider moved back onto the CREATE2 address, verified against the legacy filler). 19 files, the last 49 skip-list entries (49 → 0).With the list empty, this deletes
amsterdam_skip_list.txtand theconftest.pymachinery that applied it, and lands the accumulatedenhance-ported-testskill lessons.Every touched test fills green across its full
valid_fromrange, and the wholetests/ported_static/tree fills green on Amsterdam with 0 skips. Stacked on Pt. 2c (#3321); the diff includes the earlier slices until they merge.Related Issues or PRs
Follow-up to #3215.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture