Skip to content

fix(tests): un-skip remaining Amsterdam ported static tests and drop the skip list (Pt. 2d) - #3322

Draft
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-pt2d
Draft

fix(tests): un-skip remaining Amsterdam ported static tests and drop the skip list (Pt. 2d)#3322
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-pt2d

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Final slice of the Part 2 ported static split (chain in #3264): the remaining un-skips — including the stCreate2 Berlin-twin consolidation into single parametrized tests and the revert_depth_create_address_collision restoration (the port never actually collided; the collider moved back onto the CREATE2 address, verified against the legacy filler). 19 files, the last 49 skip-list entries (49 → 0).

With the list empty, this deletes amsterdam_skip_list.txt and the conftest.py machinery that applied it, and lands the accumulated enhance-ported-test skill lessons.

Every touched test fills green across its full valid_from range, and the whole tests/ported_static/ tree fills green on Amsterdam with 0 skips. Stacked on Pt. 2c (#3321); the diff includes the earlier slices until they merge.

Related Issues or PRs

Follow-up to #3215.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (f1aa970) to head (6e54710).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3322      +/-   ##
===================================================
- Coverage            93.50%   93.21%   -0.29%     
===================================================
  Files                  624      624              
  Lines                37070    37070              
  Branches              3394     3394              
===================================================
- Hits                 34661    34555     -106     
- Misses                1653     1723      +70     
- Partials               756      792      +36     
Flag Coverage Δ
unittests 93.21% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant