Update to IETF BLS draft 04 and add some input validations#103
Merged
Update to IETF BLS draft 04 and add some input validations#103
Conversation
hwwhww
commented
Sep 23, 2020
2 tasks
CarlBeek
approved these changes
Sep 29, 2020
Collaborator
CarlBeek
left a comment
CarlBeek
left a comment
There was a problem hiding this comment.
Aside from the validity of the point at infinity in the aggregate, this looks good to me. (To be clear, I both allowing it and disallowing it are fine with me as my reading of the specs has the behavior of Aggregate with the point at infinity as undefined.)
pacrob
added a commit
to pacrob/py_ecc
that referenced
this pull request
Oct 29, 2023
* add pre-commit * run pre-commit * skip lint on README.md as it breaks template filling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Update to IETF BLS draft 04
How was it fixed?
SK=0(point at infinity PK) is disallowed in -04 spec. UpdateKeyGen,KeyValidatecorrespondingly.KeyValidateto_CoreAggregateVerify: It wasn't a bug because_CoreAggregateVerifyitself has checkedpubkey_to_G1, but now it also needs to check the point at infinity PK._is_valid_privkey,_is_valid_pubkey,_is_valid_message, and_is_valid_signature. Reasons:FastAggregateVerify.Cute Animal Picture