Conversation
pipermerriam
approved these changes
Nov 16, 2020
ChihChengLiang
approved these changes
Nov 16, 2020
Contributor
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
Looks good to me. Added some nitpicks.
ChihChengLiang
approved these changes
Nov 16, 2020
Contributor
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
Found some duplications, other looks good to me.
Contributor
Author
|
Thanks for the reviews! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #108
How was it fixed?
Note: py_ecc doesn't provide APIs decompressed form deserialization, only compressed form deserialization.
c_flag is Trueb_flagis True, check ifa_flagis False and the value is 0.decompress_G2, checkc_flag2 == b_flag2 == a_flag2 == FalseCute Animal Picture
🦩