This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
nivida
suggested changes
Oct 8, 2019
Contributor
nivida
left a comment
nivida
left a comment
There was a problem hiding this comment.
Thanks for proposing this PR! Could you updated the CHANGELOG.md file in the root folder the 1.x branch. (I will updated and fix the the PR template asap)
gabmontes
force-pushed
the
capture-send-err
branch
from
c1eca54 to
5923816
Compare
Contributor
Author
|
@nivida changelog updated! |
nivida
approved these changes
Oct 8, 2019
This was referenced Mar 31, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Bubble up tx signing errors Resolves web3#2062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team, now that version 1.x is out, this patch (originally #2063) is relevant again for that branch. As mentioned by @nivida the issue was possibly solved in #2000 but that applies to the 2.x branch.
Please reconsider accepting this change for 1.x.