Skip to content

feat(ui): add "N in progress" indicator and clean up filter layout#201

Merged
skylenet merged 1 commit into
masterfrom
live-filter
Apr 15, 2026
Merged

feat(ui): add "N in progress" indicator and clean up filter layout#201
skylenet merged 1 commit into
masterfrom
live-filter

Conversation

@skylenet

@skylenet skylenet commented Apr 15, 2026

Copy link
Copy Markdown
Member

Summary

"N in progress" indicator

A small indicator button now sits next to the Status dropdown in RunFilters (used on both /runs and the suite detail page). It shows a pulsing blue dot + live-run count (e.g. ● 3 in progress), shares the same box height and text size as the adjacent dropdowns, and clicking it toggles the existing "In progress" status filter on/off.

  • Rendered only when liveRunsCount > 0 — zero visual noise when nothing is live.
  • On the suite detail page the count is scoped to live runs for the current suite.

Fix status filter on suite detail page

The suite detail page's filter logic was missing the status === 'running' case (so choosing "In progress" did nothing), and its status === 'passing' / 'failing' checks used total - passed regardless of whether the row is live. Now matches the RunsPage logic: live rows use the reported tests_failed for pass/fail filtering, and running filters down to in-progress rows.

Cleaner header layout on /runs

  • Row 1: Runs (N) title
  • Row 2: Metric steps: row
  • Row 3: all filter dropdowns (Client, Image, Suite, Strategy, Status, Live indicator) — left-aligned, wrapping on narrow screens

Test plan

  • TypeScript + ESLint clean
  • Manual: start a live run, confirm the indicator appears on /runs next to the Status dropdown with the correct count
  • Manual: click the indicator, confirm the runs table filters to only in-progress rows; click again to clear
  • Manual: open the suite detail page for that suite, confirm the indicator appears and is scoped to this suite
  • Manual: select "In progress" from the Status dropdown on the suite detail page, confirm the table filters correctly (was broken before this PR)
  • Manual: confirm no indicator renders when no live runs are present

- Add a small "● N in progress" button next to the Status dropdown in
  RunFilters (on both the /runs page and the suite detail page). The
  button shares the same box height and text style as the other
  dropdowns. Clicking it toggles the existing "In progress" status
  filter on/off. Hidden when there are zero live runs.
- On the suite detail page, the indicator count is scoped to live
  runs for the current suite only.
- Fix the suite detail page's status filter: it was missing the
  'running' case and its 'passing'/'failing' logic didn't account for
  live runs' tests_failed semantics. Now matches RunsPage.
- Clean up the RunsPage header layout: title on its own line, then
  the metric-steps row, then the filter dropdowns row, all left-
  aligned.
@skylenet
skylenet merged commit 2e92bad into master Apr 15, 2026
7 of 11 checks passed
@skylenet
skylenet deleted the live-filter branch April 15, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant