feat(ui): add "N in progress" indicator and clean up filter layout#201
Merged
Conversation
- Add a small "● N in progress" button next to the Status dropdown in RunFilters (on both the /runs page and the suite detail page). The button shares the same box height and text style as the other dropdowns. Clicking it toggles the existing "In progress" status filter on/off. Hidden when there are zero live runs. - On the suite detail page, the indicator count is scoped to live runs for the current suite only. - Fix the suite detail page's status filter: it was missing the 'running' case and its 'passing'/'failing' logic didn't account for live runs' tests_failed semantics. Now matches RunsPage. - Clean up the RunsPage header layout: title on its own line, then the metric-steps row, then the filter dropdowns row, all left- aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"N in progress" indicator
A small indicator button now sits next to the Status dropdown in
RunFilters(used on both/runsand the suite detail page). It shows a pulsing blue dot + live-run count (e.g.● 3 in progress), shares the same box height and text size as the adjacent dropdowns, and clicking it toggles the existing "In progress" status filter on/off.liveRunsCount > 0— zero visual noise when nothing is live.Fix status filter on suite detail page
The suite detail page's filter logic was missing the
status === 'running'case (so choosing "In progress" did nothing), and itsstatus === 'passing' / 'failing'checks usedtotal - passedregardless of whether the row is live. Now matches the RunsPage logic: live rows use the reportedtests_failedfor pass/fail filtering, andrunningfilters down to in-progress rows.Cleaner header layout on /runs
Runs (N)titleMetric steps:rowTest plan
/runsnext to the Status dropdown with the correct count