Skip to content

Fixing click-to-copy props #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naps62 merged 3 commits into from
Sep 26, 2025
Merged

Fixing click-to-copy props #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cbed24
Fixing click-to-copy props
naps62 Sep 26, 2025
1e78730
wip
naps62 Sep 26, 2025
ace3c31
wip
naps62 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/click-to-copy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {
TooltipTrigger,
} from "./shadcn/tooltip.js";

export interface ClickToCopyProps {
export interface ClickToCopyProps
extends React.HTMLAttributes<HTMLSpanElement> {
text: string | bigint | number;
children: React.ReactNode;
}
Expand Down
4 changes: 2 additions & 2 deletions components/form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ const submitLabelKnownMappings: Record<string, SubmitLabelMapping> = {
};

interface SubmitProps extends ButtonProps {
label: string | SubmitLabelMapping;
label?: string | SubmitLabelMapping;
skipDirtyCheck?: boolean;
forceLoading?: boolean;
submittingLabel?: string;
Expand Down Expand Up @@ -353,7 +353,7 @@ function Submit({
: label;

let computedLabel: string;
if (!labelMapping) {
if (!labelMapping || typeof labelMapping === "string") {
// at this point it can only be a string
computedLabel = label as string;
} else if (isLoading) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"viem": "^2.31.6",
"vite": "^7.1.5",
"vite-tsconfig-paths": "^5.1.4",
"zod": "^3.25.67"
"zod": "^4.1.11"
},
"packageManager": "yarn@4.9.2"
}
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ __metadata:
viem: "npm:^2.31.6"
vite: "npm:^7.1.5"
vite-tsconfig-paths: "npm:^5.1.4"
zod: "npm:^3.25.67"
zod: "npm:^4.1.11"
peerDependencies:
"@hookform/resolvers": ^5.2.1
"@tailwindcss/postcss": 4.1.5
Expand Down Expand Up @@ -5468,9 +5468,9 @@ __metadata:
languageName: node
linkType: hard

"zod@npm:^3.25.67":
version: 3.25.67
resolution: "zod@npm:3.25.67"
checksum: 10c0/80a0cab3033272c4ab9312198081f0c4ea88e9673c059aa36dc32024906363729db54bdb78f3dc9d5529bd1601f74974d5a56c0a23e40c6f04a9270c9ff22336
"zod@npm:^4.1.11":
version: 4.1.11
resolution: "zod@npm:4.1.11"
checksum: 10c0/ce6a4c4acfbf51d7dd0f2669c82f207d62a1f00264eef608994b94eb99d86a74c99f59b0dd3e61ef82909ee136631378b709e0908f0a02a2d5c21d0c497de5db
languageName: node
linkType: hard