DB migration and initial refactor

[galvana]

Description Of Changes

Starting point for https://ethyca.atlassian.net/browse/LJ-553. Separating out these changes first to not distract the main diff in a later PR

Code Changes

• DB migrations to add password_login_enabled and totp_secret to the fidesuser table
• Refactoring of the existing UserService into the current style

Steps to Confirm

1. Tests should pass, no new functionality. The new table columns don't have any logic yet

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
• Followup issues:
  • Followup issues created (include link)
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2025 4:31pm
fides-privacy-center	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2025 4:31pm

[JadeCara]

Only question - are there any unit tests for the service code? This might be a good opportunity to add some. :)

[codecov]

Codecov Report

Attention: Patch coverage is 85.18519% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (8ce92e8) to head (9d7d69b).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/fides/service/user/user_service.py	85.71%	5 Missing and 3 partials ⚠️
src/fides/api/models/fides_user.py	83.33%	1 Missing and 1 partial ⚠️
src/fides/api/models/fides_user_invite.py	0.00%	1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (85.18%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5984      +/-   ##
==========================================
- Coverage   86.95%   86.94%   -0.01%     
==========================================
  Files         418      418              
  Lines       25736    25757      +21     
  Branches     2779     2782       +3     
==========================================
+ Hits        22378    22395      +17     
- Misses       2758     2760       +2     
- Partials      600      602       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cypress]

fides    Run #12770

Run Properties:   Passed #12770  •  5ca76c9396: DB migration and initial refactor (#5984)

Project	fides
Branch Review	main
Run status	Passed #12770
Run duration	00m 49s
Commit	5ca76c9396: DB migration and initial refactor (#5984)
Committer	Adrian Galvan
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	5
View all changes introduced in this branch ↗︎