LJ-553 - Adds an import that prevents errors#6042
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
b1420a3 to
b778c16
Compare
galvana
approved these changes
Apr 14, 2025
b778c16 to
aad1a58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6042 +/- ##
=======================================
Coverage 86.86% 86.86%
=======================================
Files 418 418
Lines 25915 25916 +1
Branches 2826 2826
=======================================
+ Hits 22512 22513 +1
Misses 2785 2785
Partials 618 618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Victoria Cruces |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In a previous PR, the
SystemManagerimport was removed from thesrc/fides/api/models/fides_user.pyfile. This import is not used explicitly in the file, but it prevented the following error:Here is the explanation of the PR that originally added the import.
This error was obtained when running
nox -s dev -- postgres.Adding the import again fixes the problem.
Code Changes
Steps to Confirm
nox -s dev -- postgrescommand no errors are found.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works