Skip to content

LJ-553 - Adds an import that prevents errors#6042

Merged
vcruces merged 1 commit intomainfrom
LJ-553-add-import
Apr 14, 2025
Merged

LJ-553 - Adds an import that prevents errors#6042
vcruces merged 1 commit intomainfrom
LJ-553-add-import

Conversation

@vcruces
Copy link
Copy Markdown
Contributor

@vcruces vcruces commented Apr 14, 2025

Description Of Changes

In a previous PR, the SystemManager import was removed from the src/fides/api/models/fides_user.py file. This import is not used explicitly in the file, but it prevented the following error:

sqlalchemy.exc.InvalidRequestError: When initializing mapper mapped class FidesUser->fidesuser, expression 'systemmanager' failed to locate a name ("name 'systemmanager' is not defined"). If this is a class name, consider adding this relationship() to the <class 'fides.lib.models.fides_user.FidesUser'> class after both dependent classes have been defined.

Here is the explanation of the PR that originally added the import.

This error was obtained when running nox -s dev -- postgres.

Adding the import again fixes the problem.

Code Changes

  • Restore an import.

Steps to Confirm

  1. When running the nox -s dev -- postgres command no errors are found.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 7:13pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 7:13pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (1279ec2) to head (aad1a58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6042   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files         418      418           
  Lines       25915    25916    +1     
  Branches     2826     2826           
=======================================
+ Hits        22512    22513    +1     
  Misses       2785     2785           
  Partials      618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vcruces vcruces merged commit 6756321 into main Apr 14, 2025
40 checks passed
@vcruces vcruces deleted the LJ-553-add-import branch April 14, 2025 20:57
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 14, 2025

fides    Run #12815

Run Properties:  status check passed Passed #12815  •  git commit 6756321af1: LJ-553 - Adds an import that prevents errors (#6042)
Project fides
Branch Review main
Run status status check passed Passed #12815
Run duration 00m 51s
Commit git commit 6756321af1: LJ-553 - Adds an import that prevents errors (#6042)
Committer Victoria Cruces
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

This was referenced Apr 21, 2025
@tvandort tvandort mentioned this pull request May 9, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants