Skip to content

chore: update staged resource types#7871

Merged
speaker-ender merged 1 commit intomainfrom
chore/update-staged-resource-types
Apr 9, 2026
Merged

chore: update staged resource types#7871
speaker-ender merged 1 commit intomainfrom
chore/update-staged-resource-types

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Apr 9, 2026

Ticket []

Description Of Changes

Updating the staged resource type enum to reflect the BE change

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 9, 2026 4:23pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 9, 2026 4:23pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 7%
5.88% (2547/43305) 4.89% (1199/24515) 3.95% (508/12829)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.93% (330/384) 81.1% (176/217) 78.87% (56/71)

@speaker-ender speaker-ender force-pushed the chore/update-staged-resource-types branch from bb19d97 to a552cea Compare April 9, 2026 14:42
@speaker-ender speaker-ender changed the title Chore/update staged resource types chore: update staged resource types Apr 9, 2026
@speaker-ender speaker-ender force-pushed the chore/update-staged-resource-types branch from a552cea to 6ed4718 Compare April 9, 2026 16:17
chore: update staged resource types

update mock resource type value
@speaker-ender speaker-ender force-pushed the chore/update-staged-resource-types branch from 6ed4718 to 9e9ca59 Compare April 9, 2026 16:19
@speaker-ender speaker-ender marked this pull request as ready for review April 9, 2026 16:19
@speaker-ender speaker-ender requested a review from a team as a code owner April 9, 2026 16:19
@speaker-ender speaker-ender requested review from jpople and removed request for a team April 9, 2026 16:19
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused change. The enum rename from OKTA_APP to IDP_APP and the addition of CLOUD_INFRASTRUCTURE are straightforward, and all the type-level consumers (isIdentityProvider, mocks/action-center/data.ts) are correctly updated.

Three minor follow-ups noted inline:

  1. The mock factory function and its export are still named with Okta — worth renaming for consistency.
  2. mocks/data.ts uses the raw string "IDP App" instead of the enum value, which could silently drift on future renames.
  3. MOCK_IDP_APPS has no known consumers and may be dead code.

name: "Salesforce",
description: "Customer relationship management platform",
resource_type: "Okta App",
resource_type: "IDP App",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource_type is using the raw string "IDP App" rather than the enum value StagedResourceTypeValue.IDP_APP. If the enum value is renamed again in the future this will silently diverge. The rest of the file (e.g. mocks/action-center/data.ts) correctly uses the enum — worth aligning here too.

// Mock data for Okta applications
export const MOCK_OKTA_APPS = [
// Mock data for IDP applications
export const MOCK_IDP_APPS = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOCK_IDP_APPS doesn't appear to be imported anywhere in the codebase (the old MOCK_OKTA_APPS also had no consumers). If this export is only kept for future use, a comment noting that would be helpful; if it's genuinely unused, it can be removed to avoid dead code.

@speaker-ender speaker-ender added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit b913266 Apr 9, 2026
51 of 52 checks passed
@speaker-ender speaker-ender deleted the chore/update-staged-resource-types branch April 9, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants