chore: update staged resource types#7871
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
bb19d97 to
a552cea
Compare
a552cea to
6ed4718
Compare
chore: update staged resource types update mock resource type value
6ed4718 to
9e9ca59
Compare
There was a problem hiding this comment.
Clean, focused change. The enum rename from OKTA_APP to IDP_APP and the addition of CLOUD_INFRASTRUCTURE are straightforward, and all the type-level consumers (isIdentityProvider, mocks/action-center/data.ts) are correctly updated.
Three minor follow-ups noted inline:
- The mock factory function and its export are still named with
Okta— worth renaming for consistency. mocks/data.tsuses the raw string"IDP App"instead of the enum value, which could silently drift on future renames.MOCK_IDP_APPShas no known consumers and may be dead code.
| name: "Salesforce", | ||
| description: "Customer relationship management platform", | ||
| resource_type: "Okta App", | ||
| resource_type: "IDP App", |
There was a problem hiding this comment.
resource_type is using the raw string "IDP App" rather than the enum value StagedResourceTypeValue.IDP_APP. If the enum value is renamed again in the future this will silently diverge. The rest of the file (e.g. mocks/action-center/data.ts) correctly uses the enum — worth aligning here too.
| // Mock data for Okta applications | ||
| export const MOCK_OKTA_APPS = [ | ||
| // Mock data for IDP applications | ||
| export const MOCK_IDP_APPS = [ |
There was a problem hiding this comment.
MOCK_IDP_APPS doesn't appear to be imported anywhere in the codebase (the old MOCK_OKTA_APPS also had no consumers). If this export is only kept for future use, a comment noting that would be helpful; if it's genuinely unused, it can be removed to avoid dead code.
Ticket []
Description Of Changes
Updating the staged resource type enum to reflect the BE change
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works