Skip to content

chore: update staged resource types #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
speaker-ender merged 1 commit into from
Apr 9, 2026
Merged

chore: update staged resource types #7871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ta-discovery-and-detection/action-center/utils/columnBuilders/identityProviderColumns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { ColumnBuilderParams } from "./columnTypes";

export const isIdentityProvider = (
resourceType?: StagedResourceTypeValue,
): boolean => resourceType === StagedResourceTypeValue.OKTA_APP;
): boolean => resourceType === StagedResourceTypeValue.IDP_APP;

export const isIdentityProviderColumns = ({
rowClickUrl,
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/mocks/action-center/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const createMockOktaApp = (
urn: `urn:okta:app:${String(index).padStart(8, "0")}-1234-1234-1234-123456789012`,
name: overrides?.name || `App ${index}`,
description: overrides?.description || `Description for app ${index}`,
resource_type: StagedResourceTypeValue.OKTA_APP,
resource_type: StagedResourceTypeValue.IDP_APP,
diff_status: overrides?.diff_status || DiffStatus.ADDITION,
updated_at: overrides?.updated_at || "2024-01-15T10:30:00Z",
monitor_config_id: "okta_identity_provider",
Expand Down
6 changes: 3 additions & 3 deletions clients/admin-ui/src/mocks/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,13 @@ export const mockConsentableItems: ConsentableItem[] = [
},
];

// Mock data for Okta applications
export const MOCK_OKTA_APPS = [
// Mock data for IDP applications
export const MOCK_IDP_APPS = [
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOCK_IDP_APPS doesn't appear to be imported anywhere in the codebase (the old MOCK_OKTA_APPS also had no consumers). If this export is only kept for future use, a comment noting that would be helpful; if it's genuinely unused, it can be removed to avoid dead code.

{
urn: "urn:okta:app:12345678-1234-1234-1234-123456789012",
name: "Salesforce",
description: "Customer relationship management platform",
resource_type: "Okta App",
resource_type: "IDP App",
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource_type is using the raw string "IDP App" rather than the enum value StagedResourceTypeValue.IDP_APP. If the enum value is renamed again in the future this will silently diverge. The rest of the file (e.g. mocks/action-center/data.ts) correctly uses the enum — worth aligning here too.

diff_status: "addition",
updated_at: "2024-01-15T10:30:00Z",
monitor_config_id: "okta_monitor_001",
Expand Down
3 changes: 2 additions & 1 deletion clients/admin-ui/src/types/api/models/StagedResourceTypeValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ export enum StagedResourceTypeValue {
IMAGE = "Image",
I_FRAME = "iFrame",
JAVASCRIPT_TAG = "Javascript tag",
OKTA_APP = "Okta App",
IDP_APP = "IDP App",
CLOUD_INFRASTRUCTURE = "Cloud Infrastructure",
}
Loading