Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal datasets pre master #207

Merged
merged 94 commits into from
Dec 22, 2023

Conversation

ostreech1997
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Egor Baturin and others added 30 commits August 29, 2023 11:46
Refactor Pipeline `forecast` method
* added implementation

* added tests

* updated documentation

* updated `fit` signature

* updated changelog

* changed tests

* moved intervals to experimental

* updated documentation

* fixed tests

* removed duplications

* reworked `params_to_tune`

* reworked tests

* updated changelog

* updated test

* reformatted tests
* added save/load mixin

* removed placeholders from base class

* moved fixtures

* added tests

* added tests

* updated changelog

* review fixes
* support for `pandas>=1.4, <1.5`

* updated changelog
…ts (#97)

* handle prediction intervals in `TSDataset`

* updated fixtures

* reworked fixture

* added tests

* new prediction intervals logic in `reconcile`

* updated tests

* formatting

* formatted test

* updated `DeepAR`

* updated tests for `DeepAR`

* updated prediction intervals for `TFT`

* updated tests

* updated `PerSegmentModelMixin`

* updated model specific intervals tests

* added prediction intervals names to `inverse_transform` signature

* use new functionality in reversible transforms

* updated tests

* updated interval store in pipeline

* updated `HierarchicalPipeline`

* formatting

* updated changelog

* review fixes

* reworked test

* reworked inverse transforms

* updated tests

* review fixes
Aleksandr Kuznetsov and others added 22 commits November 1, 2023 14:18
added params_to_tune and test_params_to_tune
…ervals (#130)

* updated utils

* added tests

* updated `plot_forecast`

* added tests

* updated changelog

* updated comparison logic

* updated tests

* added test for warning
…143)

* added `get_historical_forecasts`

* added tests

* updated code to use `get_historical_forecasts`

* added test

* fixed test

* updated changelog

* changed tests names

* removed duplicated tests
* added `residuals_matrices` function

* updated tests

* added `ConformalPredictionIntervals`

* updated tests

* updated documentation

* updated changelog
* added empirical method

* added tests

* updated docs

* updated changelog

* review fixes

* fixed indentation
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Dec 22, 2023

🚀 Deployed on https://deploy-preview-207--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 09:55 Inactive
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (dd1ace5) 88.93% compared to head (6c166cc) 89.03%.
Report is 7 commits behind head on internal_datasets.

Files Patch % Lines
etna/analysis/forecast/plots.py 42.85% 20 Missing ⚠️
etna/datasets/internal_datasets.py 88.00% 6 Missing ⚠️
etna/models/nn/deepar_native/loss.py 94.33% 3 Missing ⚠️
etna/datasets/tsdataset.py 96.15% 2 Missing ⚠️
etna/models/base.py 66.66% 2 Missing ⚠️
etna/pipeline/hierarchical_pipeline.py 91.66% 2 Missing ⚠️
etna/transforms/decomposition/deseasonal.py 83.33% 1 Missing ⚠️
etna/transforms/math/limit.py 97.82% 1 Missing ⚠️
etna/transforms/timestamp/event.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           internal_datasets     #207      +/-   ##
=====================================================
+ Coverage              88.93%   89.03%   +0.09%     
=====================================================
  Files                    205      199       -6     
  Lines                  13026    13181     +155     
=====================================================
+ Hits                   11585    11736     +151     
- Misses                  1441     1445       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 10:33 Inactive
@ostreech1997 ostreech1997 merged commit d5a66f0 into internal_datasets Dec 22, 2023
16 checks passed
@ostreech1997 ostreech1997 deleted the internal_datasets_pre_master branch December 22, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.