Skip to content

Option to not install Click inside Quark-engine#214

Merged
haeter525 merged 2 commits intoev-flow:masterfrom
0ssigeno:environment_cli
Jul 14, 2021
Merged

Option to not install Click inside Quark-engine#214
haeter525 merged 2 commits intoev-flow:masterfrom
0ssigeno:environment_cli

Conversation

@0ssigeno
Copy link
Copy Markdown
Contributor

Closes #202

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 13, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.13%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 1.00 ⭐ 1.00 👎
Method Length 66.00 🙂 87.00 🙂 21.00 👎
Working memory 15.00 😞 15.00 😞 0.00
Quality 66.09% 🙂 61.96% 🙂 -4.13% 👎
Other metrics Before After Change
Lines 43 50 7
Changed files Quality Before Quality After Quality Change
setup.py 66.09% 🙂 61.96% 🙂 -4.13% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@krnick
Copy link
Copy Markdown
Contributor

krnick commented Jul 14, 2021

Thank you @0ssigeno for the PR!

@krnick krnick requested review from haeter525 and krnick July 14, 2021 03:39
@krnick krnick added the dependencies Pull requests that update a dependency file label Jul 14, 2021
Copy link
Copy Markdown
Member

@haeter525 haeter525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0ssigeno ,
Thank you for the fast PR. It looks great!

Copy link
Copy Markdown
Contributor

@krnick krnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @0ssigeno for your kind help :D !
We will release new version soon!

@haeter525 haeter525 merged commit 17c18a9 into ev-flow:master Jul 14, 2021
krnick added a commit that referenced this pull request Jul 15, 2021
1. Support a new Android reversing engineer framework, Rizin to analyze the APK. (#205)
2. Making `click` package optional to install. (#214) @0ssigeno
3. Improve the tainted analysis by @haeter525 in bytecode loader
4. Add an Optional Parameter Filter For JSON Rules (#212)
5. Adjust some directory names. Objects->core, Evaluator->evaluator.
6. Add VirusTotal analysis module by @pulorsok. (#195)
7. More tests for Quark by @haeter525. (#189)
8. Add a new feature to show Parent Functions' Cross-References In Rule Classification by @haeter525. (#192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have Click as an optional dependency

3 participants