Skip to content

fix: include interfaces in superclass relationships - #953

Merged
haeter525 merged 1 commit into
ev-flow:masterfrom
wenxiaojie1:fix-superclass-interface-relationships
Jul 14, 2026
Merged

fix: include interfaces in superclass relationships#953
haeter525 merged 1 commit into
ev-flow:masterfrom
wenxiaojie1:fix-superclass-interface-relationships

Conversation

@wenxiaojie1

Copy link
Copy Markdown
Contributor

Summary

  • include implemented interfaces in superclass_relationships
  • add a regression test covering a class with a parent and two interfaces

Validation

  • python -m compileall -q quark/core/apkinfo.py tests/core/test_apkinfo.py
  • git diff --check
  • verified the expected set-update behavior with a minimal local fixture

The targeted pytest invocation could not be collected locally because this machine lacks the project's pinned androguard==3.4.0a1 dependency; the new regression test will run in the repository CI environment.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (0a39d96) to head (3e5354a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          82       82           
  Lines        7185     7185           
=======================================
  Hits         5768     5768           
  Misses       1417     1417           
Flag Coverage Δ
unittests 80.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haeter525
haeter525 self-requested a review July 13, 2026 18:03

@haeter525 haeter525 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wenxiaojie1, thanks for the PR!

@haeter525
haeter525 merged commit 03e1a7f into ev-flow:master Jul 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A line in apkinfo get_superclass_relationship does not have any effect

2 participants