fix: resolve preview installs from signed channel pointers - #1033
Merged
Conversation
MAESTRO_INSTALL_CHANNEL=beta still downloaded maestro-beta-channel. That GitHub alias was removed when channels moved to immutable tags and GCS pointers, so curl | bash 404s. Resolve alpha/beta from the channel manifest, then the GitHub Releases list.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl | MAESTRO_INSTALL_CHANNEL=beta bashdownloadshttps://github.com/evalops/maestro/releases/download/maestro-beta-channel/maestro-darwin-arm64. That tag does not exist. #1032 removed the mutablemaestro-<channel>-channelGitHub aliases. Channel pointers now live atgs://evalops-prod-maestro-releases/maestro/channels/<channel>/manifest.jsonand point at immutablevX.Y.Z-beta.N/vX.Y.Z-alpha.Nreleases.scripts/install.shonmainstill constructs the deleted alias, so Damian's install 404s after the unsigned-manifest warning.This change:
MAESTRO_CHANNEL_MANIFEST_URLor the GCS channel pointermaestro-<channel>-channeldownload URLsInternal source: evalops/maestro-internal#3472
Verification
bash scripts/test-install.shshellcheck scripts/install.sh scripts/test-install.shAlso required
Dispatch
preview-channel-releasewithchannel=beta. That workflow has zero runs. There is no*-beta.*GitHub release today, so even this installer cannot install beta until the first preview release exists.Until this merges, install stable or pin
MAESTRO_INSTALL_VERSION=0.10.66.