chore: sync public mirror from internal#417
Merged
Merged
Conversation
PR SummaryMedium Risk Overview Both the TypeScript drain handler and the Rust hosted runner implement continuity extraction from runtime snapshot state (including mixed Separately, Bazel/CI naming is updated to the internal mirror ( Reviewed by Cursor Bugbot for commit 12934be. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Bazelignore references internal repo symlink name
- Updated
.bazelignoreto ignore the public Bazel convenience symlink namebazel-maestroinstead of the internal mirror name.
- Updated
- ✅ Fixed: MODULE.bazel leaks internal module name to public
- Renamed the Bazel module from
evalops_maestro_internalto the public-facingevalops_maestro.
- Renamed the Bazel module from
You can send follow-ups to the cloud agent here.
haasonsaas
force-pushed
the
sync/public-release-mirror
branch
from
84c6227 to
483d5cd
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 483d5cdbd6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
haasonsaas
force-pushed
the
sync/public-release-mirror
branch
from
6f652fe to
4d0f4db
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Rust/TypeScript key-fallback behavior diverges on malformed args
- TypeScript now falls back to the snake_case key only when the camelCase value is not an array, matching the Rust drain behavior and covered by a regression test.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 4d0f4db. Configure here.
|
Bugbot Autofix prepared a fix for the issue found in the latest run.
Preview (6202899018)diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml
--- a/.github/actionlint.yaml
+++ b/.github/actionlint.yaml
@@ -2,3 +2,4 @@
labels:
- blacksmith-*
- evalops-maestro-rbe
+ - evalops-maestro-internal-rbe
diff --git a/MODULE.bazel b/MODULE.bazel
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -1,5 +1,5 @@
module(
- name = "evalops_maestro",
+ name = "evalops_maestro_internal",
version = "0.0.0",
)
diff --git a/docs/cookbook/skills/README.md b/docs/cookbook/skills/README.md
--- a/docs/cookbook/skills/README.md
+++ b/docs/cookbook/skills/README.md
@@ -55,6 +55,21 @@
maestro skill lint .maestro/skills/reviewing-prs --describe-toolbox+## Runtime Activation Eval HarnessUse diff --git a/docs/design/EVALOPS_AGENT_CORE_PARITY.md b/docs/design/EVALOPS_AGENT_CORE_PARITY.md
+When the
+The activation manifest exposes scoped paths, toolbox entries, MCP server names, CLI Contract
diff --git a/docs/development/bazel.md b/docs/development/bazel.md You can send follow-ups to the cloud agent here. |
haasonsaas
force-pushed
the
sync/public-release-mirror
branch
from
768aaac to
12934be
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 768aaac306
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| module( | |||
| name = "evalops_maestro", | |||
| name = "evalops_maestro_internal", | |||
There was a problem hiding this comment.
Changing module(name = ...) from evalops_maestro to evalops_maestro_internal is a breaking API change for Bzlmod consumers: downstream workspaces that depend on this repo via bazel_dep(name = "evalops_maestro", ...) will no longer resolve the module name after this sync. Because this commit does not provide a compatibility/migration path, keeping the public module identity unchanged is necessary to avoid immediate dependency breakage.
Useful? React with 👍 / 👎.
|
|
||
| Trusted CI should run on the repo-scoped Buildfarm runner label | ||
| `evalops-maestro-rbe` after Deploy has registered that runner through | ||
| `evalops-maestro-internal-rbe` after Deploy has registered that runner through |
There was a problem hiding this comment.
The doc now tells operators to register evalops-maestro-internal-rbe, but the active Bazel RBE workflow still runs on evalops-maestro-rbe (.github/workflows/bazel-rbe.yml, runs-on label at line 47). Following this updated doc will provision the wrong label and leave the Bazel smoke job unschedulable on fresh environments.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12934beacd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
31
to
+32
| Trusted CI should run on the repo-scoped Buildfarm runner label | ||
| `evalops-maestro-rbe` after Deploy has registered that runner through | ||
| `evalops-maestro-internal-rbe` after Deploy has registered that runner through |
There was a problem hiding this comment.
The runner label in this doc was changed to evalops-maestro-internal-rbe, but the actual Bazel CI job still targets evalops-maestro-rbe in .github/workflows/bazel-rbe.yml (runs-on list). Following this updated guidance will register the wrong label and leave Bazel RBE jobs unschedulable in environments that provision runners from the documented value.
Useful? React with 👍 / 👎.
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evalops/maestro-internalevalops/maestroas a generated public mirror of the private source of truth103df07bcc7e84e2bc4e01428d1275a119e7dff81e379abc58b01b695553bfbd0b39c99127af120d11file(s) to copy/update and0stale file(s) to delete3Source-of-truth status
Public Mirror Drift Audit
@evalops/maestrohttps://github.com/evalops/maestro-internal@main (103df07bcc7e)https://github.com/evalops/maestro@main (09369c829785)110public_projection_has_driftSample Changed Paths
Guidance
Let internal main generate and merge the public sync PR before relying on public main.
Drift sample
Public-only commits since last generated sync
Validation
sync-public-release-mirrorworkflow inpublic-treemodeTest Plan
sync-public-release-mirrorworkflow inpublic-treemoderequire-internal-prcheck confirms internal source PR lineageStaged Rollout
evalops/maestro-internal@103df07bcc7e84e2bc4e01428d1275a119e7dff8, including existing hidden/evaluation surfaces, and keeps public package parity behind the established public-source-provenance gate.Supersedes
103df07bcc7e84e2bc4e01428d1275a119e7dff8