Skip to content

fix: harden Bazel RBE follow-up#418

Merged
haasonsaas merged 2 commits into
mainfrom
codex/bazel-rbe-maestro-20260516
May 16, 2026
Merged

fix: harden Bazel RBE follow-up#418
haasonsaas merged 2 commits into
mainfrom
codex/bazel-rbe-maestro-20260516

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

@haasonsaas haasonsaas commented May 16, 2026

Summary

  • include MODULE.bazel.lock in the Bazel RBE push path filter
  • fall back to a usable bazel binary when Go is present but GOPATH/bin/bazelisk is absent
  • resolve bazelisk from every GOPATH entry before falling back

Internal source PR: evalops/maestro-internal#1973

Verification

  • git diff --check
  • ruby YAML.load_file(.github/workflows/bazel-rbe.yml)
  • make -n bazel-test BAZEL=/bin/echo
  • fake multi-GOPATH smoke resolving bazelisk from the second GOPATH entry

@cursor
Copy link
Copy Markdown

cursor Bot commented May 16, 2026

PR Summary

Low Risk
Low risk CI/tooling change: adjusts the Bazel RBE workflow trigger paths and makes Makefile Bazel discovery more robust when Go is installed but bazelisk isn’t on GOPATH/bin.

Overview
Ensures the Bazel RBE GitHub Actions workflow reruns when MODULE.bazel.lock changes by adding it to the push paths filter.

Hardens Makefile Bazel resolution so $(BAZEL) falls back to an existing bazel on PATH (and correctly handles multi-entry GOPATH) when bazelisk isn’t available.

Reviewed by Cursor Bugbot for commit d15e329. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

This PR changes mirrored Maestro source files in the public repo, but it does not link the matching private source-of-truth PR.

Add one of these to the PR body, then re-run the check:

  • https://github.com/evalops/maestro-internal/pull/<number>
  • evalops/maestro-internal#<number>
  • maestro-internal#<number>

Mirrored files touched:

  • Makefile

@haasonsaas haasonsaas force-pushed the codex/bazel-rbe-maestro-20260516 branch from a6741fc to 417e68a Compare May 16, 2026 04:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6741fc925

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Makefile Outdated
@haasonsaas haasonsaas merged commit 09369c8 into main May 16, 2026
11 of 12 checks passed
@haasonsaas haasonsaas deleted the codex/bazel-rbe-maestro-20260516 branch May 16, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant