fix(husky): macOS bash 3.2 pre-commit without mapfile#831
Merged
Conversation
Replace mapfile with a portable while-read loop so pre-commit does not fail on stock macOS /bin/bash after the native TUI cutover. Mirrors evalops/maestro-internal#2895.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
haasonsaas
enabled auto-merge (squash)
July 20, 2026 02:13
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapfile(bash 4+) with a portable while-read loop in.husky/pre-commit/bin/bash3.2Source: https://github.com/evalops/maestro-internal/pull/2895
Test plan
mapfile -tabsent from hook