ci: remove Blacksmith runner usage - #856
Merged
Merged
Conversation
Org is dropping Blacksmith entirely (owner decision 2026-07-20). This repo already routed public CI through PUBLIC_PR_VALIDATION_RUNNER/ubuntu-latest, so the only live references were the shared main-confirmation lane in tag-release.yml and version-bump.yml (INTERNAL_CONFIRMATION_RUNNER now falls back straight to ubuntu-latest instead of a blacksmith-* label) and the self-hosted-runner label registry in actionlint.yaml. check-workflow-footguns.mjs no longer requires BLACKSMITH_RUNNER as one of the acceptable PR runner failover vars, and gains a new guardrail that fails any workflow file referencing a blacksmith-* label or BLACKSMITH_* var, so the fleet cannot silently creep back in. Test fixtures and assertions in ci-guardrails.test.ts / workflow-footguns.test.ts are updated to match (including new tests for the ban). Ref evalops/deploy#8126 (org-wide Blacksmith removal tracking issue). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FsPX4PuGaFFajJEJcT1VuD
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
This PR changes mirrored Maestro source files in the public repo, but it does not link the matching private source-of-truth PR. Add one of these to the PR body, then re-run the check:
Mirrored files touched:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Devin review on this PR flagged that evaluateNoBlacksmithReferences only scanned .github/workflows/*.yml, so a blacksmith-* reference reintroduced inside a composite action (.github/actions/**/action.yml) or back into .github/actionlint.yaml's label registry wouldn't be caught. No live reference exists today, but the guard should cover it. Scan all of .github/ recursively for any .yml/.yaml file instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FsPX4PuGaFFajJEJcT1VuD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-workflow-footguns.mjs,test/scripts/ci-guardrails.test.ts, andtest/scripts/workflow-footguns.test.tsare identical in both repos;.github/actionlint.yamland.github/workflows/*are edited per-repo since public CI already diverges from internal CI).ubuntu-latestis the correct, free target here -- unlike evalops/maestro-internal#2944, which is private and had to route to the org's owned Hetzner pool instead because GitHub-hosted Actions spend is currently hard-blocked on private repos (org budget exhausted,prevent_further_usage=true, will not be raised before it resets in August). Public-repo minutes are free and unaffected. If you're comparing the two PRs' diffs and wondering why they diverge on runner targets, that's why.ci.yml,rust.yml,release.yml) already routed throughPUBLIC_PR_VALIDATION_RUNNER || 'ubuntu-latest'with no Blacksmith fallback, so the only live references were:tag-release.yml/version-bump.yml's shared main-confirmation lane (used whengithub.repository == 'evalops/maestro-internal', i.e. dead in this repo's own runs but kept in sync with maestro-internal):INTERNAL_CONFIRMATION_RUNNER || BLACKSMITH_RUNNER || 'blacksmith-4vcpu-ubuntu-2404'->INTERNAL_CONFIRMATION_RUNNER || 'ubuntu-latest'..github/actionlint.yaml's self-hosted-runner label registry, which listed the fourblacksmith-*labels.scripts/check-workflow-footguns.mjsno longer requiresvars.BLACKSMITH_RUNNERas one of the acceptable PR runner failover vars, and gains a new guardrail (evaluateNoBlacksmithReferences) that recursively scans all of.github/-- workflows, composite actions under.github/actions/**, and.github/actionlint.yaml-- for ablacksmith-*label orBLACKSMITH_*var, so the fleet can't silently creep back in from anywhere in.github/, not just workflow files.test/scripts/ci-guardrails.test.tsandtest/scripts/workflow-footguns.test.tsare updated to match (dead-branch assertions in this repo's test file that referenced Blacksmith -- inherited from the shared maestro-internal test content -- are cleaned up too; new tests cover the ban, including the composite-action/actionlint.yaml coverage).require-internal-prgateThis repo's
public-source-provenance.ymlrequires PRs that touch mirrored source files to link the matchingevalops/maestro-internalPR in the body (it is not a blanket ban on direct public PRs --.github/workflows/*and.github/actionlint.yamlare explicitly exempt as public-only files;scripts/check-workflow-footguns.mjsand the two test files are the mirrored files that triggered it). Added the link above; gate passes.Left in place (and why)
CHANGELOG.mdmentions of Blacksmith (historical release notes) -- left untouched, it's a record of what was true at the time.Test plan
node ./scripts/run-vitest.js --run test/scripts/-- 43 files / 497 tests passed.node scripts/check-workflow-footguns.mjs-- guardrails passed.actionlint .github/workflows/tag-release.yml .github/workflows/version-bump.yml-- clean.bunx @biomejs/biome@1.9.4 checkon touched JS/TS files -- clean.Co-authored by Claude Fable 5.