fix(observability): expose recent Sandboxwich event metrics - #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sandboxwich alerting now measures recent lease-expiry, cleanup-failure, and guest-token-issuance events with explicitly windowed gauges. The previous rules applied
increase()to durable row-count gauges, so retention changes could look like event bursts. Lease and token windows preserve tenant scoping; cleanup remains operator-global.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace(second run passed; the first run's unrelated worker race passed on exact rerun)Scope
This PR changes only Sandboxwich metric production and its regression coverage. It does not mutate production directly. The matching deploy PR changes the alert expressions to consume these new metric names.