Convert first clinic wins into subscriptions - #203
Draft
evangauer wants to merge 6 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
EMAIL_COMPANY_ADDRESSis missing or structurally not a physical postal address. The check is PHI/secret-safe and occurs before rendering or provider contact.Why
A completed real clinic visit is OpenVPM's strongest validated product-use signal. This release turns that signal into a measurable, privacy-safe subscription opportunity while preventing false Add billing messages, duplicate/stale promotional sends, and promotional email with a non-postal footer identity.
Safety and rollout
FIRST_CLINIC_WIN_EMAIL_ENABLEDdefaults tofalse.FIRST_CLINIC_WIN_EMAIL_LAUNCH_ATmakes hosted health fail.EMAIL_COMPANY_ADDRESS; set and operator-verify the real physical US postal address before deploying this stack. The value is never exposed by health responses or logs.Validation
pnpm --filter @openpims/web test— 378 files passed, 3 skipped; 3,937 tests passed, 6 skipped.pnpm --filter @openpims/web type-checkpnpm --filter @openpims/db type-checkpnpm --filter @openpims/email type-checkpnpm --filter @openpims/web buildpnpm --filter @openpims/db db:generate— no schema changes after committed migration/snapshot.git diff --checkStack
This is intentionally stacked on
codex/subscription-conversion-reliability/ PR #202. Merge and validate that base first; do not merge this PR directly tomainbefore the stack is resolved.