Refactor sync to use home/ directory

[evansenter]

Summary

Simplify the sync strategy by moving all syncable dotfiles into a home/ directory.

Before: rsync with 10+ --exclude flags (brittle, grows with each new file type)
After: rsync home/ ~ (simple, self-documenting)

Changes

• Move all syncable dotfiles into home/:
  • .aliases, .bin/, .exports, .gitconfig, .tmux.conf
  • .vim/, .vimrc, .zsh_prompt, .zshrc
• Simplify sync_dotfiles() to single rsync command
• Update git pull to use main branch
• Update CLAUDE.md with new file paths

Benefits

• To add a new dotfile, just put it in home/ - no bootstrap.sh changes needed
• Clear separation: home/ = synced, everything else = not synced
• Easier to understand at a glance what gets installed

Test plan

• Run ./bootstrap.sh -f and verify all files sync to ~
• Verify .DS_Store is not synced

🤖 Generated with Claude Code

[claude]

Pull Request Review

This is an excellent refactoring that significantly improves the maintainability of the dotfiles sync process. The move from exclusion-based to inclusion-based syncing is a much cleaner approach.

✅ Strengths

1. Architectural Improvement

• The home/ directory pattern is a well-established dotfiles convention
• Self-documenting structure: files in home/ = files that get synced
• Eliminates the brittle --exclude flag maintenance burden

2. Code Quality

• Simplified rsync command (bootstrap.sh:78-84) is much cleaner
• Correct branch update (master → main) in bootstrap.sh:11
• CLAUDE.md accurately updated with new file paths
• All file moves properly tracked by git (preserves history)

3. Completeness

• All syncable files correctly moved to home/
• Documentation comprehensively updated
• Test plan covers the critical sync functionality

⚠️ Issues Found

CRITICAL: Missing .DS_Store exclusion

The old rsync had --exclude ".DS_Store" (line 79 of old bootstrap.sh), but the new version syncs everything in home/. This means if a .DS_Store file gets created in home/, it will be synced to ~.

Recommended fix:

rsync \
  --exclude ".DS_Store" \
  --archive \
  --verbose \
  --human-readable \
  --force \
  --no-perms \
  home/ ~

While the test plan confirms .DS_Store isn't currently synced, the missing exclusion creates a latent bug. macOS automatically creates .DS_Store files in directories, so one could appear in home/ at any time.

📝 Minor Observations

Documentation Accuracy

• bootstrap.sh:76-100 range in CLAUDE.md is correct ✓
• All file path references properly updated ✓

Backward Compatibility

• This is a breaking change for anyone with local modifications
• However, for a personal dotfiles repo, this is acceptable
• Users can re-run bootstrap.sh after pulling to sync new locations

🔒 Security & Performance

• Security: No concerns. The changes are purely organizational
• Performance: Negligible impact. Rsync with source directory is as fast as exclusion-based approach
• No new vulnerabilities introduced

✅ Recommendations

1. Add .DS_Store exclusion (critical - see above)
2. Consider adding .DS_Store to .gitignore in the home/ directory as defense-in-depth
3. Optional: Add a migration note to README.md for users pulling this change

Summary

This is a well-executed refactoring with clear benefits. The only blocker is the missing .DS_Store exclusion, which should be added before merging. Once that's addressed, this PR will be ready to merge.

Verdict: Approve with requested changes (add .DS_Store exclusion)