feat: Add automatic event bus synchronization on every prompt - #99
Conversation
Code ReviewSummaryThis PR adds automatic event bus synchronization by fetching events on every user prompt via a new Issues FoundCriticalNone. ImportantNone. Suggestions
VerdictREQUEST_CHANGES - A few minor suggestions around timeout configuration and limit consistency. The core implementation looks solid with proper graceful degradation and state management. Automated review by Claude Code |
Code ReviewSummaryThis PR adds automatic event bus synchronization by creating a new Issue #75 Requirements VerificationAll requirements from the linked issue are addressed:
Code Quality NotesGood practices observed:
Design choices reviewed:
VerdictAPPROVE - Clean implementation that addresses all issue requirements. Code follows shell best practices with proper error handling and graceful degradation. Automated review by Claude Code |
Feedback AddressedImplemented
Skipped
|
Code ReviewSummaryThis PR adds automatic event bus synchronization on every prompt via a new Issue #75 VerificationAll requirements from the linked issue are addressed:
Previous Feedback StatusAll suggestions from previous reviews have been addressed in the "Feedback Addressed" comment:
VerdictAPPROVE - Clean implementation with proper error handling, graceful degradation, and XDG-compliant state management. All issue requirements met and previous feedback addressed. Automated review by Claude Code |
Add UserPromptSubmit hook (prompt-events.sh) that fetches new events from the event bus before processing each user prompt. Also update session-start.sh to catch up on recent events at session startup. Uses event-bus-cli with --track-state for incremental polling via ~/.local/state/claude/last_event_id. Events are filtered to exclude session_registered/session_unregistered noise. Closes #75 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Addresses claude-review suggestion: document why prompt-events uses --limit 20 while session-start uses --limit 10 (active sessions benefit from more event context). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code ReviewSummaryThis PR adds automatic event bus synchronization by creating a Issue #75 VerificationAll requirements from the linked issue are fully addressed:
Code Quality AssessmentWell-implemented patterns:
Previous Feedback Status:
VerdictAPPROVE - Clean implementation with proper error handling, graceful degradation, and XDG-compliant state management. All issue #75 requirements met and previous feedback addressed. Automated review by Claude Code |
Summary
prompt-events.shhook that fetches new events from the event bus on everyUserPromptSubmitsession-start.shto catch up on recent events at session startupUserPromptSubmithook insettings.jsonCLAUDE.mdUses
event-bus-cliwith--track-statefor incremental polling via~/.local/state/claude/last_event_id. Events are filtered to excludesession_registered/session_unregisterednoise.Test plan
prompt-events.shfetches new events correctlysession-start.shshows recent events on startupevent-bus-clinot installedCloses #75
🤖 Generated with Claude Code